packages/router/src/RouterLink.ts (2)

1-31: Prefer type-only import for AnchorHTMLAttributes to avoid any runtime import risk

Move AnchorHTMLAttributes to a separate type-only import for consistency and to keep bundlers from attempting to load it at runtime.

-import {
+import {
   defineComponent,
   h,
   PropType,
   inject,
   computed,
   reactive,
   unref,
   VNode,
   UnwrapRef,
   VNodeProps,
   AllowedComponentProps,
   ComponentCustomProps,
   getCurrentInstance,
   watchEffect,
   // this is a workaround for https://github.com/microsoft/rushstack/issues/1050
   // this file is meant to be prepended to the generated dist/src/RouterLink.d.ts
   // @ts-ignore
   ComputedRef,
   // @ts-ignore
   DefineComponent,
   // @ts-ignore
   RendererElement,
   // @ts-ignore
   RendererNode,
   // @ts-ignore
   ComponentOptionsMixin,
   MaybeRef,
-  AnchorHTMLAttributes,
 } from 'vue'
+import type { AnchorHTMLAttributes } from 'vue'

---

369-379: Typing strategy achieves goal; verify behavior with dynamic boolean custom bindings

The conditional props cleanly allow anchor events/attrs when custom !== true and exclude them when custom === true, and href is properly omitted. One edge case: <RouterLink :custom="someBool" ...> (or TSX custom={someBool} where someBool: boolean) may not be assignable to either branch of the union (true vs false|undefined), causing a TS error. If that’s acceptable, consider documenting it; otherwise, we may need a broader strategy (tradeoff: allowing dynamic booleans typically re-allows anchor attrs).

You can extend the dts test with:

// dynamic boolean: today this likely errors (by design). Decide if we want to support it.
const isCustom: boolean = Math.random() > 0.5
// @ts-expect-error: dynamic boolean not supported by narrowed props
expectError(<RouterLink to="/" custom={isCustom} onFocus={() => {}} />)
// explicit false should allow anchor attrs/handlers
expectTypeOf<JSX.Element>(<RouterLink to="/" custom={false} onFocus={() => {}} target="_blank" />)
// explicit true should forbid anchor attrs/handlers
// @ts-expect-error
expectError(<RouterLink to="/" custom={true} onFocus={() => {}} />)

packages/router/test-dts/components.test-d.tsx (1)

30-40: Great coverage; add a couple of assertions for explicit custom={false} and ARIA/data fallthrough

Tests capture the core behaviors. Consider adding:

• acceptance of custom={false} with events/attrs
• an ARIA/data attribute to ensure broad fallthrough coverage

// allows when explicitly false
expectTypeOf<JSX.Element>(<RouterLink to="/" custom={false} onFocus={() => {}} target="_blank" />)
// allows ARIA/data attrs
expectTypeOf<JSX.Element>(<RouterLink to="/" aria-label="Home" data-testid="rl" />)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/router/test-dts/components.test-d.tsx (1)

30-40: LGTM! Comprehensive type tests for RouterLink anchor behavior.

The new tests correctly verify:

• Event handlers (onFocus, onClick) and anchor attributes (target, rel) are allowed when custom is not set
• href is always disallowed (derived from to)
• Event handlers are disallowed when custom={true}

Optional enhancement: Consider adding a test for custom={false} explicitly to verify that anchor attributes are also allowed in that case (not just when custom is omitted):

expectTypeOf<JSX.Element>(
  <RouterLink to="/" custom={false} onFocus={() => {}} />
)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro